fix: remove Swift from fallback chunking extensions #7325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on PR #7309 discussion and validation from @adamhill, Swift parser is stable and functional. The assumption about parser instability was incorrect. Changes: - Removed Swift from fallbackExtensions list in supported-extensions.ts - Updated tests to expect Swift to use proper parser instead of fallback - Added comprehensive documentation of lessons learned in docs/lessons-learned/ This ensures Swift files use the proper tree-sitter parser for code indexing.
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| ".vb", // Visual Basic .NET - no dedicated WASM parser | ||
| ".scala", // Scala - uses fallback chunking instead of Lua query workaround | ||
| ".swift", // Swift - uses fallback chunking due to parser instability | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
Could we add a brief comment here explaining why Swift was removed? Something like:
This would help future maintainers understand the history without needing to dig through PRs.
| @@ -0,0 +1,125 @@ | |||
| # Lessons Learned: Swift Parser Investigation | |||
Contributor
Author
There was a problem hiding this comment.
This is an excellent lessons learned document! For a document of this length, would it be helpful to add a table of contents at the top? It would make navigation easier for future readers looking for specific sections.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
I'll investigate the issue a bit more, this change prevented crashes for some people, I think we need to investigate a bit more before removing this fallback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes Swift from the fallback chunking extensions list based on the learnings from PR #7309.
Context
In PR #7309, an incorrect assumption was made that the Swift tree-sitter parser was unstable and causing VS Code crashes. This led to adding Swift to the fallback chunking list. However, as @adamhill correctly pointed out, the Swift parser is stable and functional - developers work with Swift projects in VS Code daily without issues.
Changes
fallbackExtensionslist insrc/services/code-index/shared/supported-extensions.tsdocs/lessons-learned/swift-parser-investigation.mdLessons Learned
This change embodies the key lessons from the Swift parser investigation:
Testing
Related Issues
Important
Removes Swift from fallback chunking list to use tree-sitter parser, updates tests, and adds documentation on lessons learned.
fallbackExtensionsinsupported-extensions.tsto use tree-sitter parser.parser.vb.spec.tstests to reflect Swift's proper parser usage.swift-parser-investigation.mddocumenting lessons learned from the Swift parser investigation.This description was created by
for 3f22cc9. You can customize this summary. It will automatically update as commits are pushed.